Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8486

Warning for undefined variables is slow in jruby

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 5.5.1, PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Epic Link:
    • Team:
      Froyo
    • Sprint:
      Platform Core KANBAN
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      Internal performance related issue - not user facing.
    • QA Risk Assessment:
      Needs Assessment

      Description

      The use of exceptions here https://github.com/puppetlabs/puppet/blob/master/lib/puppet/parser/scope.rb#L530-L543 when running in :warning mode (the default) is slow on JRuby. With a single undefined variable referenced in my hiera hierarchy I found handling this without exceptions resulted in a 20% runtime improvement.

      I suspect both the throw and the exceptions are unnecessary.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            patrick Patrick Carlisle
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support