Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8667

resource 'tidy' should be less chatty

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 5.5.0
    • Fix Version/s: PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      The Tidy resource type now uses the debug log level for its "File does not exist" message, instead of the info level. This means that resources of this type will no longer emit the message by default when the target of the resource has already been cleaned from disk.
      Show
      The Tidy resource type now uses the debug log level for its "File does not exist" message, instead of the info level. This means that resources of this type will no longer emit the message by default when the target of the resource has already been cleaned from disk.
    • QA Risk Assessment:
      No Action

      Description

      When using the 'tidy' resource to cleanup files, this resource will always report that a given file it manages does not, or no longer, exist. The fact that the file to be tidied up is not present is the expected result, and the report about this fact is unnecessarily verbose.

      This is the style of message that is produced:

          Info: /Stage[main]/[...]/Tidy[<title>]: File does not exist

      at each and every puppet agent run.

      Suggested fix:

      In file /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/tidy.rb, at line 337: change

        info _("File does not exist")

      to

        debug _("File does not exist")

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                jacob.helwig Jacob Helwig
                Reporter:
                pk Paul Kranenburg
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: