Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8702

Allow (or maybe require) responses to be streamed from Puppet::Rest::Client

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      The API of Puppet::Rest::Client streams response bodies by default

      Show
      The API of Puppet::Rest::Client streams response bodies by default
    • Team:
      Server
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      Needs Assessment

      Description

      The existing HTTP client code in Puppet had the capability to stream responses bolted on fairly late. For this new client, we should make sure that streaming is built into the design. HTTPClient provides an API for chunking responses (https://github.com/nahi/httpclient/blob/master/lib/httpclient.rb#L69-L73) that we should be able to incorporate fairly easily. Because it does not return a raw response object, but rather checks status internally and throws an error if the response is bad, this will require us to change the way we do error handling, which is another argument (besides the obvious one around safety) for having all responses be streamed.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  maggie Maggie Dreyer
                  Reporter:
                  maggie Maggie Dreyer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: