Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8898

Change default input_method for Task object type

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Bolt
    • Sprint:
      Bolt Kanban
    • Release Notes:
      New Feature
    • Release Notes Summary:
      The input_method property of Tasks now defaults to undef rather than the string "both". This allows more flexibility in defaults and what input_methods we choose to support in the future.
    • QA Risk Assessment:
      Needs Assessment

      Description

      When a Task is run using BOLT puppet code is used to parse the task metadata. If `input_method` is not defined the default is set to `both`. https://github.com/puppetlabs/puppet/blob/a5385a74bdf7eb754dafed1f557563d97eb68bcd/lib/puppet/pops/pcore.rb#L74 

      In the case where Bolt is used to run a task the default `input_method` should be set based on the combination of programming language the task is implemented in and the transport. For example if a powershell task is run over winrm the default `input_method` should be `powershell`.

      Proposed change: Puppet sets default value for `input_method` to `nil` when `input_method` is not defined. The responsibility for setting appropriate `input_method` for running tasks in Bolt will be handled in the various transport implementations. 

      Relates to BOLT-536

      https://tickets.puppetlabs.com/browse/BOLT-536

       

       

       

       

       

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  cas.donoghue Cas Donoghue
                  Reporter:
                  cas.donoghue Cas Donoghue
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: