Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-8900

"puppet facts upload" face only tries first master in server_list

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 5.5.1
    • Fix Version/s: PUP 6.13.0
    • Component/s: None
    • Template:
      PUP Bug Template
    • Epic Link:
    • Team:
      Coremunity
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Needs Assessment
    • CS Priority:
      Reviewed
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      "puppet facts upload" now tries each server entry in the server_list setting in the same way that "puppet agent" does. Previously it only tried the first entry in the server_list setting.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Puppet Version: 5.5.1
      Puppet Server Version: 5.5.2 (2018.1.0.41)
      OS Name/Version: RHEL 7

      When a node's puppet.conf specifies multiple masters in server_list the facts upload face only tries the first master in the list. If this fails due to a hostname lookup failure on the first master the face exits with an error, rather than trying the second master.

      Steps to reproduce:

      • remove any "server" configs from puppet.conf
      • add the following "server_list" configuration: "foo.example,actual-master.example" (where "actual-master.example" is the working master address, and "foo.example" is not resolvable to an IP address)
      • run "puppet facts upload"

      Desired Behavior:

      • the face should gracefully fail over to the second master in the server_list and complete the facts upload successfully

      Actual Behavior:

      • the face fails with the following error message:

      # puppet facts upload
      Notice: Uploading facts for 'pe-201730-master.puppetdebug.vlan' to: 'foo.example'
      Error: Failed to open TCP connection to foo.example:8140 (getaddrinfo: Name or service not known)
      Error: Try 'puppet help facts upload' for usage
      

      I'm attaching the output of "puppet facts upload --debug --trace" as well.

      This face (and the facts endpoint in puppetserver) were (re)added in this PR: https://github.com/puppetlabs/puppet/pull/6434

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              josh Josh Cooper
              Reporter:
              jesse.reynolds Jesse Reynolds
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support