Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9104

YAML safe_load prevents aliases

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 6.0.0
    • Fix Version/s: PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
      PUP Bug Template
    • Team:
      Platform Core
    • Method Found:
      Needs Assessment
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      Hide
      YAML safe_load was too strict and refused to load local aliases in a yaml file.
      Now it is possible to use such aliases.
      Show
      YAML safe_load was too strict and refused to load local aliases in a yaml file. Now it is possible to use such aliases.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Puppet Version: current master, e.g. ddd5610aa9ffb5eb9da13521f1fc68e562a2e0b3
      Puppet Server Version: n/a
      OS Name/Version: n/a

      Actual Behavior:

      In some cases puppet creates a transactionstore.yaml that are not able to be read back, causing 

      Error: Transaction store file /home/david/.puppetlabs/opt/puppet/cache/devices/pavm/state/transactionstore.yaml is corrupt (Unknown alias: 1); replacing

      Desired Behavior:

      No errors or stacktraces on regular puppet use.

      Reproduction:

      Thomas Franklin has put together a detailed description and a potential fix in https://github.com/Thomas-Franklin/puppet/commit/49b8e023c6c9bb551bd0ce21648a604042c490ff

      The issue is also visible in the panos acceptance pipelines: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/modules/view/networking/view/panos/view/master/job/forge-module_puppetlabs-panos_intn-sys_full-pe-future-master/8/

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. PUP-7834 Change all calls to YAML.load into YAML.safe_load

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              david.schmitt David Schmitt
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support