Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9130

tagging with undef should not add a tag

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
      PUP Bug Template
    • Acceptance Criteria:
      Hide

      It should not tag anything when giving a tag as undef.

      Show
      It should not tag anything when giving a tag as undef .
    • Team:
      Platform Core
    • Method Found:
      Needs Assessment
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      No need to release-note since bug never released (PUP-9112 is for Puppet 6.0.0).
    • QA Risk Assessment:
      Needs Assessment

      Description

      In PUP-9112 we stopped translating puppet's undef to Ruby symbol :undef in the resource API. As a consequence, if trying to tag with an undef value this ended up as an empty string (nil.to_s is an empty string). This was then correctly flagged as an error.

      The change in PUP-9112 thus revealed a long standing bug, where tagging with undef actually tagged the resource with the string "undef", which is completely useless since it cannot be used or queried using undef.

      Any undef/nil values should simply be dropped in the tagging process.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                henrik.lindberg Henrik Lindberg
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: