Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9134

FromDataHash should not crash if hash with __ptype key is not a type

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 6.0.0
    • None
    • None
    • Platform Core
    • Needs Assessment
    • Not Needed
    • Very special case caused by non user facing logic
    • Needs Assessment

    Description

      In case FromDataHash is given a hash where a key is "__ptype", and its value is not a type, it should then assume that what it is looking at is just a hash instead of crashing.

      This is caused by the ToStringifiedConverter not converting to a safe form when seeing such a hash. The ToStringifyConverter should simply generate "reserved-key: __ptype" for such hashes since the result is for human consumption.

      Attachments

        Activity

          People

            Unassigned Unassigned
            henrik.lindberg Henrik Lindberg
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support