Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9134

FromDataHash should not crash if hash with __ptype key is not a type

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 6.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
      PUP Bug Template
    • Team:
      Platform Core
    • Method Found:
      Needs Assessment
    • Release Notes:
      Not Needed
    • Release Notes Summary:
      Very special case caused by non user facing logic
    • QA Risk Assessment:
      Needs Assessment

      Description

      In case FromDataHash is given a hash where a key is "__ptype", and its value is not a type, it should then assume that what it is looking at is just a hash instead of crashing.

      This is caused by the ToStringifiedConverter not converting to a safe form when seeing such a hash. The ToStringifyConverter should simply generate "reserved-key: __ptype" for such hashes since the result is for human consumption.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            henrik.lindberg Henrik Lindberg
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support