[PUP-9163] Lexer incorrectly identifying list starts inside heredocs - Puppet Jira Server

XML

Word

Printable

Release Notes:
Bug Fix
Release Notes Summary:

Hide
When using interpolation inside a heredoc the position and location information for the interpolated expressions were wrong. This could lead to two problems;
* if using {{[]}} expressions a mysterious Syntax Error would be raised if an
seemingly arbitrary position after the interpolation contained white-space.
* If there were errors in the interpolation they could end up being reported for the wrong line and position on the line.

This is now fixed.

Show
When using interpolation inside a heredoc the position and location information for the interpolated expressions were wrong. This could lead to two problems; * if using {{[]}} expressions a mysterious Syntax Error would be raised if an seemingly arbitrary position after the interpolation contained white-space. * If there were errors in the interpolation they could end up being reported for the wrong line and position on the line. This is now fixed.

Square brackets that are:

Are sometimes being incorrectly lexed as TOKEN_LISTSTART.

Create test.pp:

$xxxxxxx = @("END")

${facts['os']['family']}

XXXXXXX XXX

END

notice($xxxxxxx)

Puppet apply it.

Some text to appear showing the OS family.

Error: Could not parse for environment production: Syntax error at '[' (file: /Users/alexharvey/git/home/puppet-test/test.pp, line: 2, column: 14)

Note the space inside XXX XX. That space is matching in the lexer on this line here, leading to the '[' being lexed as TOKEN_LISTSTART.

relates to

PUP-9306 Regression in heredoc parser in 5.5.8