Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9211

Module paths with common root cause incorrect name location validation errors.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 5.5.6
    • Fix Version/s: PUP 5.5.7, PUP 6.0.3
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      Validation should not report an error in this case.

      Show
      Validation should not report an error in this case.
    • Team:
      Coremunity
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Fixed issue where overlapping module paths would cause an incorrect illegal location deprecation warning or error.
    • QA Risk Assessment:
      Needs Assessment

      Description

      When one module path is a substring of another, users can get incorrect name location validation errors.

      kris.bosland@kris:puppet % bx puppet apply --modulepath ../tmp/test/modules:../tmp/test/modules.common  -e 'class test { include bash }; include test'                             ±[5.5.6^0]
      Warning: Unacceptable location. The name 'bash' is unacceptable in file '/Users/kris.bosland/work/tmp/test/modules.common/bash/manifests/init.pp' (file: /Users/kris.bosland/work/tmp/test/modules.common/bash/manifests/init.pp, line: 1, column: 1)
      Notice: Compiled catalog for kris.bosland-c02kf9eafft1 in environment production in 0.57 seconds
      Error: Mac OS X PKG DMGs must specify a package source.
      Error: /Stage[main]/Bash/Package[shells/bash]/ensure: change from 'absent' to 'present' failed: Mac OS X PKG DMGs must specify a package source.
      Notice: Applied catalog in 0.02 seconds
      kris.bosland@kris:puppet % cat ../tmp/test/modules.common/bash/manifests/init.pp                                                                                                   ±[5.5.6^0]
      class bash {
          package { "shells/bash":
              ensure => installed,
          }
      }
      kris.bosland@kris:puppet %

       

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  kris.bosland Kris Bosland
                  Reporter:
                  ltning Eirik Øverby
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: