Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9257

Improve heredoc syntax checkers

    XMLWordPrintable

Details

    • New Feature
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 6.1.0
    • None
    • New Feature
    • Hide

      Parser validation finds and reports heredocs syntax issues

      Heredoc syntax checking is now performed during validation, unless the heredoc contains any interpolated expressions. This includes manifest and EPP template syntax checks. Heredocs with interpolation are checked during evaluation. Prior to this release, heredoc syntax checks were run only during evaluation.

      By default, heredocs are text unless otherwise specified with the end-of-text tag, such as @(EOT:json), @(EOT:app), or @(EOT:epp). To check syntax in heredocs, run `puppet parser validate`.
      Show
      Parser validation finds and reports heredocs syntax issues Heredoc syntax checking is now performed during validation, unless the heredoc contains any interpolated expressions. This includes manifest and EPP template syntax checks. Heredocs with interpolation are checked during evaluation. Prior to this release, heredoc syntax checks were run only during evaluation. By default, heredocs are text unless otherwise specified with the end-of-text tag, such as @(EOT:json), @(EOT:app), or @(EOT:epp). To check syntax in heredocs, run `puppet parser validate`.
    • Needs Assessment

    Description

      Heredoc syntax checkers currently run as part of evaluation. This is done because a heredoc may contain interpolation and thus the final result will not be known until the heredoc is evaluated. There are however many cases (most even) where a heredoc is just static text and this makes it possible to validate the syntax statically (and for static text then skip the check at evaluation time).

      We should also add syntax checkers for PP, EPP.

      Attachments

        Activity

          People

            Unassigned Unassigned
            henrik.lindberg Henrik Lindberg
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support