Details
-
Bug
-
Status: Accepted
-
Normal
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
-
Windows 10 - 1803
Puppet 5.5.x gem
Ruby 2.4
-
Night's Watch
-
1
-
Manual Test
-
Needs Assessment
Description
PUP-9216 was merged earlier, which sets System ACE entries to full control. This triggers a failure in pxp-agent's tasks.run_puppet.rb test, specifically here based on the stack trace.
Representative failure output:
Successful task expected to have no output on stderr. --- expected +++ actual @@ -1 +1,2 @@ -nil +"\e[1;33mWarning: An attempt to set mode 416 on item C:/ProgramData/PuppetLabs/puppet/cache/reports/xln2koezj7avuqx.delivery.puppetlabs.net/201810110803.yaml would result in the group, SYSTEM, to have less than Full Control rights. This attempt has been corrected to Full Control\e[0m +"
|
—
Pull Request https://github.com/puppetlabs/puppet/pull/7167 was raised to fix one place where set_mode was used, however some other testing exposed there are other places where set_mode is used to set inappropriate permissions on Windows platforms; e.g. https://github.com/puppetlabs/puppet/pull/7167#issuecomment-430682091
This issue will track the work to find all of the set_mode call sites and audit them for appropriate-ness on Windows platforms. And then raise fix PRs where needed.