Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9300

Text Fragmentation in Exception Message

    Details

    • Template:
      PUP Bug Template
    • Team:
      Coremunity
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Inspection
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      Needs Assessment

      Description

      In our localization tool (Transifex), I encountered the following text:

      "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failed with"

      A localizable string should be a complete phrase.

      I found the string in puppet.pot and then tracked it to this file:

      https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719

      From looking at the code, this text is an exception message.

      --- 

      Here are two possible resolutions:

      1) Add placeholder to string "

      "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failed with %{more_info}"

      2) Remove "Failed with" from the string

      "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. "

      If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed (minor).

      If we go with resolution #2, 2 string resources will have to be changed.

      Can you point me where the exception catcher code is?

       

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                erwin.hom Erwin Hom
                Reporter:
                erwin.hom Erwin Hom
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support