[PUP-9639] Windows package resource does not remove trailing whitespace - Puppet Jira Server

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Critical
Resolution: Fixed
Affects Version/s: PUP 5.5.12, PUP 6.0.5, PUP 6.4.0
Fix Version/s: PUP 5.5.16, PUP 6.0.10, PUP 6.4.3, PUP 6.5.0
Component/s: None
Labels:

Master Config:
Monolithic
Master OS:
RHEL 6 (x86_64)
Team:
Night's Watch
Story Points:
3
Sprint:
PR - 2019-05-02, PR - 2019-05-15, PR - 2019-05-29
Method Found:
Customer Feedback

CS Priority:
Major
Zendesk Ticket IDs:
50334
Zendesk Ticket Count:
1

Release Notes:
Bug Fix
Release Notes Summary:

Hide
When reading from the Windows Registry we can end-up with data that will
cause issues in the upstream services, such as null bytes sequence

This commit updates the Windows Registry read method to replace null byte
sequence with a space.

Show
When reading from the Windows Registry we can end-up with data that will cause issues in the upstream services, such as null bytes sequence This commit updates the Windows Registry read method to replace null byte sequence with a space.

QA Risk Assessment:
Needs Assessment

Description

Package Inspector in Windows is reading in the version number without removing trailing whitespace, which when submitted to the DB as a fact causes the updated facts for that agent to be discarded.

As seen on a Windows machine:

package { 'McAfee SiteAdvisor Enterprise':

  ensure => '1.7.0.144                                                                                                                                                                                                                                                      ',

Which is passed into a fact as:

"name": "node.puppet.com",

"values": {

"_puppet_inventory_1": {

"packages": [

["McAfee SiteAdvisor Enterprise", "1.7.0.144\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000", "windows"]

Which in turn causes PuppetDB to reject facts from the node, including facts other than the one with the null bit:

2017-10-06 17:32:11,961 ERROR [p.p.command] [5,166,564] [replace facts] Retrying after attempt 0 for node.puppet.com, due to: org.postgresql.util.PSQLException: ERROR: invalid byte sequence for encoding "UTF8": 0x00

org.postgresql.util.PSQLException: ERROR: invalid byte sequence for encoding "UTF8": 0x00

Attachments

Issue Links

relates to

PUP-10536 Puppet windows package provider fails if there are garbage characters after an embedded NULL

Closed

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...

(1 mentioned in)

Activity

People

Assignee:: Gheorghe Popescu

Reporter:: Paul Schaffer

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 2019/04/10 2:56 PM

Updated:: 2022/12/05 2:47 AM

Resolved:: 2019/05/29 1:32 AM