Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-9815

`bundle exec rake syntax` reports invalid manifests as valid

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 6.5.0, PUP 6.6.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
      PUP Bug Template
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      Puppet Version: 6.5.0, 6.6.0

      First reported on #puppet-dev slack by Christoph Maser.

      Since puppet 6.5.0, `bundle exec rake syntax` doesn't work anymore.

      $ export PUPPET_GEM_VERSION="6.4.2"
      $ bundle update
      ...
      Using puppet 6.4.2
      ...
      $ bundle exec rake  validate
      ---> syntax:manifests
      Could not parse for environment *root*: Syntax error at '' (file: themeier-systemd_cron/manifests/init.pp, line: 39, column: 11)   # < exit 1
      $ unset PUPPET_GEM_VERSION
      $ bundle update
      ...
      Using puppet 6.6.0 (was 6.4.2)
      ...
      $ bundle exec rake  validate
      ---> syntax:manifests
      ---> syntax:templates
      ---> syntax:hiera:yaml   < exit 0
      

      I've used `git bisect` to identify the breaking change as

      6103786d11955371fd6327b42a3ed933c146829c is the first bad commit
      commit 6103786d11955371fd6327b42a3ed933c146829c
      Author: Jesse Scott <jesse@puppetlabs.com>
      Date:   Wed Jun 13 17:34:37 2018 -0700
       
          (PUP-8984) Implement --render-as=json in `puppet parser validate`
          
          Tools like the Puppet Development Kit which invoke `puppet parser
          validate` on behalf of the user need a consistent, machine-readable
          output format so that they don't have to rely on complex and brittle
          regular expressions matching output that may change between Puppet
          releases.
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                alexjfisher Alexander Fisher
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support