Uploaded image for project: 'R10K'
  1. R10K
  2. RK-258

r10k should still exit 0 when it encounters symlinks

    XMLWordPrintable

    Details

    • Template:
    • Acceptance Criteria:
      • r10k no longer exits non-zero when symlinks are encountered in a forge module
      • r10k continues to log at some appropriate level when symlinks are encountered in a forge module
    • Story Points:
      1
    • Sprint:
      CODEMGMT 2016-07-27
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Previously, if r10k encountered a symbolic link when deploying a Forge module to an environment, it would log an error and then later when the process was finished, it would terminate with a non-zero exit code. It will now log a warning and exit 0 in this scenario.
      Show
      Previously, if r10k encountered a symbolic link when deploying a Forge module to an environment, it would log an error and then later when the process was finished, it would terminate with a non-zero exit code. It will now log a warning and exit 0 in this scenario.

      Description

      In RK-103, r10k started logging an error when symlinks were encountered while extracting a Forge module. Unfortunately, the mechanism by which it does this causes r10k to exit 1 at the end of the run. This issue doesn't seem serious enough to warrant a non-zero exit code for the whole process. We should just log the notification at a lower level and not allow an exception to bubble all the way up to the point where it causes a non-zero exit.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jesse Jesse Scott
              Reporter:
              jesse Jesse Scott
              QA Contact:
              Zach Reichert
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support