Uploaded image for project: 'R10K'
  1. R10K
  2. RK-302

semantic_puppet version inclusion of 1.0.1 from puppet causes breakages in r10k

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Enterprise in the Cloud
    • Story Points:
      2
    • Sprint:
      ETC 2017-08-22, ETC 2017-9-5
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      No Action

      Description

      r10k's gem requirement of ~> 0.1.0 wants a version between 0.1.0 and 0.2.0, but given the dependency of 1.0.1 from puppet there are breakages for users.

      One suggestion is to modify the r10k gemspec to be [">= 0.10", "< 2"]

      As per Jesse Scott r10k used exactly one method call from semantic_puppet and it might be best to just eliminate the hard dependency entirely

      Something similar was done for metadata-json-lint: https://github.com/voxpupuli/metadata-json-lint/pull/86/files it uses semantic_puppet method if available, but has an internal fallback

      https://github.com/voxpupuli/metadata-json-lint/pull/86/files
      Make SemanticPuppet completely optional and remove dependency on Puppet by scotje · Pull Request #86 · voxpupuli/metadata-json-lint
      This commit changes the two validations that currently use SemanticPuppet to only use that library if it is already available on the load path. If not, it falls back to less robust built-in alterna...

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  libby Libby Molina
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: