Uploaded image for project: 'R10K'
  1. R10K
  2. RK-324

Improve r10k Bionic support

    Details

    • Template:
    • Team:
      Server
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      This resolves the race condition that was causing a Ruby ASYNC bug around pipes on Ubuntu 18.04.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Recently we've seen a number of transients when running r10k with the shellgit provider on Bionic, something along the lines of:

        INFO	 -> Environment 20ea53274b2d4e10b2b11c836a2c53bd is now at 6f53f35825de443d8363559d96893295f5bd840a
        INFO	 -> Deploying environment /etc/puppetlabs/code/environments/2f88fdc7213c4619bfed72828bdb7d89
        [ASYNC BUG]   (6)
        EPIPE
        
        ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-linux]
        
        [NOTE]
        You may have encountered a bug in the Ruby interpreter or extension libraries.
        Bug reports are welcome.
        For details: http://www.ruby-lang.org/bugreport.html
      

      This (unresolved) issue with Sensu on FreeBSD looks similar: https://github.com/sensu/sensu/issues/1388 and is most likely an issue with a Ruby change of behavior/bug with how we're implementing shelling out to git in https://github.com/puppetlabs/r10k/blob/master/lib/r10k/util/subprocess/runner/posix.rb or managing IO with https://github.com/puppetlabs/r10k/blob/master/lib/r10k/util/subprocess/runner/pump.rb

      I think next steps would be to be to repro the issue on a Bionic VM outside of CI.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                justin Justin Stoller
                Reporter:
                justin Justin Stoller
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support