Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-115

Concurrent access to the CRL can corrupt it

    XMLWordPrintable

    Details

    • CS Priority:
      Major
    • CS Frequency:
      3 - 25-50% of Customers
    • CS Severity:
      4 - Major
    • CS Business Value:
      4 - $$$$$
    • CS Impact:
      The CRL process does not seem to lock the file as it should, this can lead to duplicate indexes or corruption. As we have more customers with more dynamic workloads that add or remove nodes automatically this will become more and more of an issue.
    • Zendesk Ticket IDs:
      33162,34556
    • Zendesk Ticket Count:
      2
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      We have synchronized write access to the CRL, so that each revoked certificate will write the CRL in serial, preventing corruption from competing requests writing to the file.

      Description

      It seems like there is no locking when the server is revoking a cert and updating the CRL file. This should have similar locking as when it issues new certs and updates the inventory and serial files.

      The code in question is here: https://github.com/puppetlabs/puppet-server/blob/master/src/clj/puppetlabs/puppetserver/certificate_authority.clj#L977-L989

      This is the same issue as PUP-2189 really, except for the clojure code.

        Attachments

          Issue Links

          is blocked by

          Task - A task that needs to be done. SERVER-1999 Investigate puppet server CRL handling for atomicity

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          relates to

          Task - A task that needs to be done. SERVER-2641 Backport CRL API serialization

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. PUP-2189 The CRL can get corrupted if two workers revoke certs at same time

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-2125 SPIKE: Investigate storing CA files in postgres as a means to provide HA

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Accepted

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-2565 Puppet Server should use atomic file operations when updating CA state

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Ready for Engineering

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              dalen Erik Dalén
              QA Contact:
              Erik Dasher
              Votes:
              0 Vote for this issue
              Watchers:
              23 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support