Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-1761

Change profiler.enabled setting default to 'true' and remove extra profile logging

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: SERVER 5.0.0
    • Component/s: None
    • Labels:
      None
    • Release Notes:
      Known Issue
    • Release Notes Summary:
      Puppetserver 5 enables profiling by default. Profiling was enabled via configuration in Puppet Enterprise without impact, and as such is being made default behavior for open source Puppetserver.
    • QA Risk Assessment:
      Needs Assessment

      Description

      This ticket covers two changes to the Puppet profiler service implementation:

      1) Change the default for the profiler.enabled Trapperkeeper setting to true.

      Previously, the default for the profiler.enabled Trapperkeeper setting had been false. In PE, we've been setting the default to true since the initial release of metrics functionality in Puppet Server. Where that has not seemed to create any known functional issues and having it set to true by default would make it easier for users to utilize the new status/metric endpoint and dashboard functionality being done for SERVER-1259, changing the default to true seems reasonable to do.

      2) Remove the debug logging being done in the MetricsPuppetProfiler class for profiled metrics.

      In the PE metrics implementation, the PuppetProfiler class does not do any debug logging for profiled metrics either.

      Current OSS users that might have been setting the profiler.enabled setting in the puppetserver.conf file to true in order to get the extra debug output would now need to set the puppet.conf profile setting to true instead, as PE users have done to date.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                adrien Adrien Thebo
                Reporter:
                jeremy.barlow Jeremy Barlow
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: