Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-2344

Log stack traces for uncaught exceptions in ring-middleware

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: SERVER 5.3.6, SERVER 6.0.2
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Froyo
    • QA Risk Assessment:
      Needs Assessment

      Description

      We have middleware that catches otherwise uncaught exceptions and returns a 500 with the Exception message or kind. We do not want to return a stacktrace over the wire, however we should log the stacktrace locally at an error level. We currently only log the Exception message which is not helpful. See: https://github.com/puppetlabs/ring-middleware/blob/master/src/puppetlabs/ring_middleware/core.clj#L205

        Attachments

          Activity

            People

            Assignee:
            justin Justin Stoller
            Reporter:
            justin Justin Stoller
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support