Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-2420

Allow including certname in logs for compilation errors

    Details

    • Type: Improvement
    • Status: Accepted
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Puppet Server
    • Labels:
      None
    • QA Risk Assessment:
      Needs Assessment

      Description

      Puppet Version: 5.5.8
      Puppet Server Version: 5.3.6
      OS Name/Version: Centos 7

      I'd like it if the Puppetserver process were capable of including the certname of the relevant node in log output when a compilation error occurs (or really, when every any log message is emitted from the puppetserver in the process of working on a specific node).

      I don't need this to be included by default in the log messages. If the Certname was added to SLF4J's Mapped Diagnostic Context I'd be perfectly happy to adjust our logback configuration to take advantage of that (in fact, I'd be happier that way than with it in the message body, since we're already using logback-gelf to have puppetserver send structured log messages and this way I won't need to parse the certname out of the message body).

      Desired Behavior:

      **Certname of node being processed is available to logback for association with log messages.

      Actual Behavior:

       

      Certname of node being processed does not appear to be available to logback in MDC (or in any other manner that I can figure out).

       

      Note that the certificate name does appear to be available to the request/access logger, but I'm more interested in the puppetserver's actually logs than the request logs.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  adam.gardner Adam Gardner
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated: