Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-3098

JRuby pool lock lifecycle should be logged at INFO level

    XMLWordPrintable

Details

    • Enhancement
    • The JRuby lock lifecycle of request, acquire, release is now logged at the INFO level, rather than DEBUG.
    • Needs Assessment

    Description

      *Puppet Server Version: Latest
      *OS Name/Version: Any

      The JRuby pool used by Puppet Server and PE Orchestrator has a lock functionality that is used, notably by Code Manager, to drain in-flight requests in order to gain exclusive access to file resources used by JRuby.

      The lifecycle of requesting, acquiring, and releasing this lock has a critical impact on JRuby availability and thus on service performance. The following messages around the lock lifecycle logged at DEBUG level:

      2021-09-25T17:01:38.280Z DEBUG [clojure-agent-send-off-pool-4596] [p.s.j.jruby-core] Acquiring lock on JRubyPool...
      2021-09-25T17:01:38.280Z DEBUG [clojure-agent-send-off-pool-4596] [p.s.j.jruby-core] Lock acquired
      2021-09-25T17:02:36.446Z DEBUG [clojure-agent-send-off-pool-4596] [p.s.j.jruby-core] Lock on JRubyPool released
      

      Due to the critical nature of this workflow, these messages should be logged at INFO level to facilitate post-mortem debugging.

      Attachments

        Activity

          People

            chuck Charlie Sharpsteen
            chuck Charlie Sharpsteen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support