Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-448

Change default max-active-instances to not exceed 4 JRubies

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: SERVER 1.0.8, SERVER 2.1.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Sub-team:
    • Story Points:
      1
    • Sprint:
      Server Jade 2015-03-18, Server Jade 2015-04-01

      Description

      Longer-term, we need to make some more refined adjustments to the algorithm / process that Puppet Server uses to calculate the default max-active-instances for JRubies. The details of the longer-term plans are covered by SERVER-364.

      For the forthcoming release of 1.X Puppet Server, however, we need to at least make a targeted improvement which caps this default number at a value that should be safer to use with the default 2Gb JVM Heap which is configured.

      For the next release, this ticket proposes changing default-pool-size in "jruby_puppet_core.clj" from...

      (+ 2 (ks/num-cpus))
      

      ...to...

      (min 4 (max (- (ks/num-cpus) 1) 1))
      

      The above would ensure that by default the number of JRubies would never exceed 4 and would never exceed 1 less the number of cores on the node. The latter would be useful for ensuring that the master doesn't consume every available core on the node under high workload situations, at least by default.
      ___
      Risk assessment: Medium (QA will perform functional review, but no automated testing)
      Probability: Low (small simple code change)
      Severity: Low (High, could cause OOM errors)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              erik Erik Dasher
              Reporter:
              jeremy.barlow Jeremy Barlow
              QA Contact:
              Erik Dasher Erik Dasher
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support