Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-544

don't read two copies of the request body in for JRuby requests

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • SERVER 1.1.0, SERVER 2.1.0
    • None
    • None
    • 1
    • Server Jade 2015-04-15, Server Jade 2015-04-29, Server Jade 2015-05-13

    Description

      Due to some conflicting opinions about how request bodies should be processed between the Ruby Puppet code and ring's 'params' middleware, our current code has the unfortunate behavior of reading the body of the HTTP request into memory twice for any requests that are routed into the JRuby layer.

      We can prevent this by duplicating a few functions from the ring middleware library in our own code base, which isn't awesome, but seems preferable to the unnecessary extra memory usage (which can be a pretty big chunk of RAM for requests like catalog/report).
      _________
      Risk Assessment: Low
      Severity: Low
      Probability: Low

      Attachments

        Issue Links

          Activity

            People

              erik Erik Dasher
              chris Chris Price
              Erik Dasher Erik Dasher
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support