Uploaded image for project: 'Puppet Server'
  1. Puppet Server
  2. SERVER-994

Log message about environment cache invalidation needs improvement

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Template:

      Description

      This log message ...

      2015-10-30 11:20:26,424 INFO  [clojure-agent-send-off-pool-27] [p.s.j.puppet-environments] Marking all registered environments as expired.
      

      ... could use some improvement.

      First of all, it is logged per-JRuby, and that's confusing - it looks like the cache is being invalidated N times (where N is the number of JRubies); and technically, it is, since the caching is per-JRuby; but if you just see a block of those messages go by, it can be confusing - especially so for an end-user who might not understand the guts of Puppet Server.

      So, perhaps it should only be logged once at INFO level for the entire operation, and the per-JRuby messages could be bumped down to DEBUG. It would also be clearer if they mentioned that they were per-JRuby, perhaps by including the JRuby instance ID.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            kevin.corcoran Kevin Corcoran
            QA Contact:
            Erik Dasher
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support