Uploaded image for project: 'Trapperkeeper'
  1. Trapperkeeper
  2. TK-347

Support directories and paths in TK's "bootstrap-config" CLI argument

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: TK 1.4.1
    • Component/s: None
    • Labels:
      None

      Description

      Currently, the bootstrap-config CLI argument in TK only accepts a single file path as its value. It parses that file and interprets it as the list of services to boot the app with.

      This ticket would cover some extensions to that logic:

      1. The argument should also tolerate a directory being passed in. If the value passed in is a directory, then TK should slurp in all of the ".cfg" files in that directory to come up with the list of TK services var names, and then pass that list off to the existing code that validates and boots them.
      2. The argument should tolerate a colon-delimited path being passed in. In this case, it should split the value on ":" characters, and for each entry in the path, perform the same logic of slurping in service varnames from the files/directories, and then pass that list off to the existing code that validates and boots them. (The current code for dealing with the "--config" argument should hopefully be able to be re-used for this part, because it already has support for splitting paths on ":" chars, checking to see if the path entries are files or dirs, etc.)

      These changes should be backward compatible, so that any consumer that wishes to continue passing in a simple path to a single file should be able to keep working as before.

        Attachments

          Issue Links

            Activity

            Hide
            joe.pinsonault Joe Pinsonault added a comment -

            should it split on commas to be consistent with the --config argument?

            Show
            joe.pinsonault Joe Pinsonault added a comment - should it split on commas to be consistent with the --config argument?
            Hide
            chris Chris Price added a comment -

            Joe Pinsonault ah, yeah, whatever --config does, definitely.

            Show
            chris Chris Price added a comment - Joe Pinsonault ah, yeah, whatever --config does, definitely.
            Hide
            jeremy.barlow Jeremy Barlow added a comment -

            Merged to trapperkeeper#master at 2158095.

            Show
            jeremy.barlow Jeremy Barlow added a comment - Merged to trapperkeeper#master at 2158095 .
            Hide
            kurt.wall Kurt Wall added a comment -

            Resolved per QA risk assessment.

            Show
            kurt.wall Kurt Wall added a comment - Resolved per QA risk assessment.

              People

              • Assignee:
                Unassigned
                Reporter:
                chris Chris Price
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support