Uploaded image for project: 'Trapperkeeper'
  1. Trapperkeeper
  2. TK-401

Status Service: log more information when a callback times-out

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Template:
    • Team:
      Next Generation
    • Story Points:
      3
    • Sprint:
      NG 2016-12-28
    • CS Priority:
      Needs Priority

      Description

      When a status callback times-out, it currently logs "Status callback timed out, shutting down background task"; this isn't terribly helpful at the moment because it doesn't indicate which callback timed-out (i.e. which TK service). The service name should be added to that log message ... and perhaps any other information which might help debug this situation.

      Here's a real-world example of this:

      2016-06-20 23:59:22,126 ERROR [clojure-agent-send-off-pool-17636] [p.t.s.s.status-core] Status callback timed out, shutting down background task
      2016-06-20 23:59:22,127 ERROR [clojure-agent-send-off-pool-17636] [p.t.s.s.status-core] #error {
       :cause nil
       :via
       [{:type java.util.concurrent.CancellationException
         :message nil
         :at [java.util.concurrent.FutureTask report FutureTask.java 121]}]
       :trace
       [[java.util.concurrent.FutureTask report FutureTask.java 121]
        [java.util.concurrent.FutureTask get FutureTask.java 192]
        [clojure.core$deref_future invoke core.clj 2186]
        [clojure.core$future_call$reify__6736 deref core.clj 6683]
        [clojure.core$deref invoke core.clj 2206]
        [puppetlabs.trapperkeeper.services.status.status_core$eval29953$guarded_status_fn_call__29958$fn__29959$fn__29969 invoke status_core.clj 233]
        [puppetlabs.trapperkeeper.services.status.status_core$eval29953$guarded_status_fn_call__29958$fn__29959 invoke status_core.clj 233]
        [puppetlabs.trapperkeeper.services.status.status_core$eval29953$guarded_status_fn_call__29958 invoke status_core.clj 216]
        [puppetlabs.trapperkeeper.services.status.status_service$reify__43521$service_fnk__5254__auto___positional$reify__43528 get_status status_service.clj 43]
        [puppetlabs.trapperkeeper.services.status.status_service$eval43479$fn__43480$G__43471__43485 invoke status_service.clj 7]
        [puppetlabs.trapperkeeper.services.status.status_service$eval43479$fn__43480$G__43470__43491 invoke status_service.clj 7]
        [clojure.core$partial$fn__4527 invoke core.clj 2495]
        [clojure.core$partial$fn__4531 invoke core.clj 2506]
        [puppetlabs.code_manager.status$status invoke status.clj 17]
        [clojure.core$partial$fn__4529 invoke core.clj 2500]
        [puppetlabs.trapperkeeper.services.status.status_core$eval29953$guarded_status_fn_call__29958$fn__29959$fn__29962 invoke status_core.clj 235]
        [clojure.core$binding_conveyor_fn$fn__4444 invoke core.clj 1916]
        [clojure.lang.AFn call AFn.java 18]
        [java.util.concurrent.FutureTask run FutureTask.java 266]
        [java.util.concurrent.ThreadPoolExecutor runWorker ThreadPoolExecutor.java 1142]
        [java.util.concurrent.ThreadPoolExecutor$Worker run ThreadPoolExecutor.java 617]
        [java.lang.Thread run Thread.java 745]]}
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                justin Justin Stoller
                Reporter:
                kevin.corcoran Kevin Corcoran
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support