Uploaded image for project: 'Trapperkeeper'
  1. Trapperkeeper
  2. TK-456

Scheduler Service: Log more information when a job errors out

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Accepted
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Template:
    • Team:
      Froyo
    • CS Priority:
      Reviewed
    • Zendesk Ticket IDs:
      41398
    • Zendesk Ticket Count:
      1
    • QA Risk Assessment:
      Needs Assessment

      Description

      When a scheduled job crashes it logs "scheduled job threw error
      java.lang.NullPointerException: null", which doesn't help to identify what job failed or how to get more information about it.

      For example, here's what we currently display:

      2017-10-20 12:09:17,351 ERROR [pool-2-thread-2] [p.t.s.s.scheduler-core] scheduled job threw error 
      java.lang.NullPointerException: null 
      at puppetlabs.trapperkeeper.services.scheduler.scheduler_core$wrap_with_error_logging$fn__46332.invoke(scheduler_core.clj:16) 
      at clojure.lang.AFn.run(AFn.java:22) 
      at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
      at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) 
      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) 
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
      at java.lang.Thread.run(Thread.java:748) 
      

      It would be nice to include some detail about the job that failed, such as its name or function - any additional information would improve troubleshooting around this area.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            paul.schaffer Paul Schaffer
            Votes:
            1 Vote for this issue
            Watchers:
            9 Start watching this issue

              Dates

              Created:
              Updated:

                Zendesk Support