Uploaded image for project: 'Trapperkeeper'
  1. Trapperkeeper
  2. TK-466

TrapperKeeper apps should log a message at the default log level when reloaded

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: TK 1.5.1
    • Fix Version/s: TK 1.5.6
    • Component/s: None
    • Labels:
    • Template:
      PUP Bug Template
    • Team:
      Froyo
    • CS Priority:
      Normal
    • CS Frequency:
      2 - 5-25% of Customers
    • CS Severity:
      2 - Annoyance
    • CS Business Value:
      4 - $$$$$
    • CS Impact:
      The impact to users of this isn't very high, but it could have a significant impact in reducing the time to resolution for support tickets which both saves support time, and also results in happier customers.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Consider the following log snippet:

      :10:09,008 INFO  [qtp1612415802-116] [puppetserver] Puppet Compiled catalog for pe-201735-master.puppetdebug.vlan in environment production in 5.81 seconds:10:09,008 INFO  [qtp1612415802-116] [puppetserver] Puppet Caching catalog for pe-201735-master.puppetdebug.vlan:10:10,161 INFO  [qtp1612415802-116] [puppetserver] Puppet 'replace_catalog' command for pe-201735-master.puppetdebug.vlan submitted to PuppetDB with UUID 2ecc1018-9fc5-445c-bbfc-1fd072d5ce6f:10:26,782 INFO  [qtp1612415802-114] [puppetserver] Puppet 'store_report' command for pe-201735-master.puppetdebug.vlan submitted to PuppetDB with UUID 167f6b60-d04b-4b24-af42-aea53fda13bc:10:34,669 INFO  [async-dispatch-4] [p.s.j.jruby-metrics-service] JRuby Metrics Service: stopping metrics sampler job:10:34,671 INFO  [async-dispatch-4] [p.s.j.jruby-metrics-service] JRuby Metrics Service: stopped metrics sampler job:10:34,673 INFO  [async-dispatch-4] [p.s.j.i.jruby-agents] Draining JRuby pool.:10:34,675 INFO  [async-dispatch-4] [p.s.j.i.jruby-agents] Borrowed all JRuby instances, proceeding with cleanup.:10:34,698 INFO  [clojure-agent-send-pool-3] [p.s.j.i.jruby-internal] Cleaned up old JRubyInstance with id 1.:10:34,699 INFO  [clojure-agent-send-pool-3] [p.s.j.i.jruby-agents] Finished draining pool.
      

      When exactly did Puppet Server handle a SIGHUP? It's not clear from the logs when the reload cycle was kicked off.

      We do log a message at debug level when handling the HUP signal:

      https://github.com/puppetlabs/trapperkeeper/blob/1.5.5/src/puppetlabs/trapperkeeper/internal.clj#L305

      This should be boosted to the default log level for Puppet, INFO.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            chuck Charlie Sharpsteen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support