Uploaded image for project: 'Trapperkeeper'
  1. Trapperkeeper
  2. TK-481

Add Java 11 support to trapperkeeper-metrics

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Done
    • None
    • None
    • TrapperKeeper
    • Froyo
    • Reviewed
    • 38249,38783,40560
    • 3
    • Needs Assessment

    Description

      The testsuite for trapperkeeper-metrics currently has a couple of issues when run under Java 11. The first is that flatland/ordered, which is a transitive dependency of trapperkeeper via circleci/clj-yaml must be at version 1.5.7 or higher to resolve an overloaded method:

      $ lein test
      ...blah...
      Exception in thread "main" java.lang.IllegalArgumentException: Must hint overloaded method: toArray, compiling:(flatland/ordered/set.clj:19:1)
      	at clojure.lang.Compiler.analyzeSeq(Compiler.java:6875)
      	at clojure.lang.Compiler.analyze(Compiler.java:6669)
      	at clojure.lang.Compiler.analyze(Compiler.java:6625)
      	at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:6001)
      	at clojure.lang.Compiler$LetExpr$Parser.parse(Compiler.java:6319)
      ...
      

      Once that is cleared up, there are some concerning warnings about Reflection that should be cleaned up:

      WARNING: An illegal reflective access operation has occurred
      WARNING: Illegal reflective access by dynapath.defaults$eval27060$fn__27061 to method java.net.URLClassLoader.addURL(java.net.URL)
      WARNING: Please consider reporting this to the maintainers of dynapath.defaults$eval27060$fn__27061
      WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      WARNING: All illegal access operations will be denied in a future release
       
      lein test puppetlabs.metrics-test
       
      lein test puppetlabs.trapperkeeper.services.metrics.metrics-core-test
       
      lein test puppetlabs.trapperkeeper.services.metrics.metrics-service-test
       
      lein test puppetlabs.trapperkeeper.services.metrics.metrics-testutils
       
      Ran 31 tests containing 326 assertions.
      0 failures, 0 errors.
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              chuck Charlie Sharpsteen
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support