Uploaded image for project: 'Trapperkeeper'
  1. Trapperkeeper
  2. TK-488

Disable Jolokia debug mode by default in trapperkeeper.metrics

    XMLWordPrintable

    Details

    • Template:
    • Team:
      Froyo
    • Method Found:
      Customer Feedback
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      SEE PE-29464
    • QA Risk Assessment:
      Needs Assessment

      Description

      trapperkeeper-metrics currently configures the Jolokia service with debug logging enabled by default:

      https://github.com/puppetlabs/trapperkeeper-metrics/blob/1.2.3/src/clj/puppetlabs/trapperkeeper/services/metrics/jolokia.clj#L38-L41

      However, this setting unfortunately does more than just providing access to DEBUG-level messages. It also causes some things to be logged at ERROR level, like backtraces for "missing" JMX items that should just result in a 404 message (SERVER-2826):

      https://github.com/rhuss/jolokia/blob/v1.6.2/agent/core/src/main/java/org/jolokia/http/HttpRequestHandler.java#L264-L266

      Having Jolokia in debug mode by default gives access to information that can be useful, but logging stack traces for "normal" 404s means that information is coming at a cost of a drastically lowered signal-to-noise ratio in the logs.

      I can't recall an incident where we needed to debug Jolokia in the past couple years, so it's likely a good trade-off to just shut debug off by default and enable it in metrics.conf when needed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              chuck Charlie Sharpsteen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support