[CPR-391] Fedora packages have odd distro tag Created: 2016/11/28  Updated: 2018/06/13  Resolved: 2018/06/08

Status: Resolved
Project: Community Package Repository
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: Michael Stahnke Assignee: Molly Waggett
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
is blocked by BKR-1118 Add method to install repo using buil... Resolved
is blocked by BKR-1342 Move the acceptance rake tasks & inst... Closed
is blocked by FACT-1816 Add dependency on beaker-puppet and u... Closed
is blocked by HI-596 Bump beaker-puppet and use common ci ... Closed
is blocked by MCO-831 Add beaker-puppet dependencies and sw... Closed
is blocked by PCP-832 Add beaker-puppet dependency and swit... Closed
is blocked by PUP-8416 Remove old acceptance code that now l... Closed
is blocked by PUP-8267 Rewrite acceptance rake tasks to leve... Closed
relates to CPR-409 Ensure beaker and other PL projects c... Resolved
relates to CPR-407 Enable packaging to ship fedora packa... Closed
relates to CPR-408 Update yum.pl.com to cease using f pr... Closed

Error rendering 'issue-templates-customfield'. Please contact your Jira administrators.

Team: Release Engineering
Story Points: 2
Sprint: Release Engineering Kanban
QA Risk Assessment: Needs Assessment


For a filename like puppet-agent-1.5.2-1.fedoraf23.x86_64.rpm I would expect distro tag (the part after the release field to be either Feodra 23, for 23. They are some weird combination of both. That seems really odd to me. Can we fix it?

Comment by Molly Waggett [ 2017/02/06 ]

Melissa Stone I'm keeping this as In Progress because this ticket won't be totally resolved once PR#441 is merged. We'll still have to actually add `dist` to the platform configs for all relevant projects, etc.

Comment by Joshua Partlow [ 2017/02/10 ]

Assuming that the puppet-agent tarballs names at http://agent-downloads.delivery.puppetlabs.net aren't affected by this, I don't think it will have an impact on puppetlabs-pe_repo and PE's frictionless installer.

I do think it affects puppetlabs-puppet_agent upgrade module here: https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/manifests/install.pp#L120
Hopefully a patch is as simple as updating that string and validating an upgrade with fedora, but I'm not positive...hrm, well, probably more complicated because I assume this will vary across different release versions (of PE or puppet-agent)?

Comment by James Wagner [ 2017/02/13 ]

CC Kevin Imber Fergal Gribben Tony Vu

Comment by Rob Braden [ 2017/02/22 ]

Fairly soon we'll be changing the repos that we're shipping into ('puppet' instead of 'PC1') - should we hold these changes until that cutover (the puppet5 timeframe)?

Comment by Molly Waggett [ 2017/05/19 ]

PRs up, waiting for beaker work on RE-8333.

Comment by Geoff Nichols [ 2017/07/07 ]

We ran into issues in puppet-agent CI that required us to reverse the changes in https://github.com/puppetlabs/puppet-agent/pull/1103.

Comment by Michael Stahnke [ 2017/07/31 ]

We've been pulling this ticket along for a pretty long time now (more than a quarter), are we any closer to actually closing it out or should we give up? Close it?

Comment by Molly Waggett [ 2017/07/31 ]

Michael Stahnke This is essentially done, we're just waiting for some beaker updates (that are also almost done) so we don't break things.

Comment by Melissa Stone [ 2017/09/12 ]

Note: tests will also have to me modified when we make this change

fedora_prefix = ((variant == 'fedora') ? 'f' : '')

Comment by Molly Waggett [ 2017/12/04 ]

Melissa Stone ^ what tests are you referencing? in what repo?

Comment by Melissa Stone [ 2017/12/04 ]

probably integration tests in puppet and or puppetserver, anything that installs the puppet-agent package

Generated at Mon Sep 28 15:57:50 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.