[FACT-1446] acceptance: Improve the windows user check in facter/acceptance/test/facts/windows.rb Created: 2016/06/24  Updated: 2017/04/05  Resolved: 2017/04/05

Status: Resolved
Project: Facter
Component/s: Windows
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Normal
Reporter: Glenn Sarti Assignee: John O'Connor
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to IMAGES-360 Create JJB for Packer Image Acceptanc... Resolved
relates to FACT-1442 facter/acceptance/test/facts/window.r... Resolved
Template:
Team: Agent
Story Points: 2
Sprint: Agent 2017-04-05
QA Risk Assessment: No Action

 Description   

In FACT-1442 the regular expression used to validate the user identity from facter on windows was modified to be more broad. This was to expedite the CI pipelines passing due to Windows 10 being added. However the regex may be too broad and there value is never actually verified.

This ticket should;

  • Investigate whether it is possible to verify that the value returned from facter is actually true


 Comments   
Comment by John O'Connor [ 2017/04/04 ]

Moving into current sprint and activating as PR is up for this issue due to facter testing issues discovered in packer/imaging acceptance testing.

Comment by John O'Connor [ 2017/04/04 ]

This also noted in IMAGES-360

Comment by John O'Connor [ 2017/04/04 ]

Maggie Dreyer are you able to take over review of this change - not urgent, but thought it worthwhile to put up the PR for the additional windows platforms under this ticket rather than IMAGES-360.

Tx

Comment by Maggie Dreyer [ 2017/04/04 ]

Yes, I'll try it out today.

Comment by Geoff Nichols [ 2017/04/04 ]

PR #1541 merged to facter#master at https://github.com/puppetlabs/facter/commit/dad9df8bb898cd8d5e46fc7fd0d929cf119dca17.

Comment by Geoff Nichols [ 2017/04/05 ]

Passing CI run at https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent%20suite%20pipelines/job/platform_puppet-agent_intn-van-sys_suite-daily-facter-master/47/.

Generated at Wed Apr 01 14:47:26 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.