[HI-493] Update install.rb to install .bat files on windows Created: 2016/01/15  Updated: 2016/03/17  Resolved: 2016/02/10

Status: Closed
Project: Hiera
Component/s: Windows
Affects Version/s: None
Fix Version/s: HI 3.1.0

Type: Bug Priority: Normal
Reporter: Melissa Stone Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Epic Link: Windows Vanagon
Story Points: 1
Sprint: RE 2016-02-03, RE 2016-02-10
Release Notes: Not Needed

 Description   

Our current way of installing hiera drops a ruby script into the bindir that doesn't work on windows. We need install.rb to install a .bat file instead (which we also either need to write or copy over from puppet_for_the_win)



 Comments   
Comment by Melissa Stone [ 2016/01/15 ]

cc/ Michael Smith

Comment by Melissa Stone [ 2016/01/19 ]

It looks like this is already done at https://github.com/puppetlabs/hiera/blob/master/install.rb#L245

We're getting a hiera.bat file installed with these contents:

@echo off
setlocal
set RUBY_BIN=%~dp0
set RUBY_BIN=%RUBY_BIN:\=/%
"%RUBY_BIN%ruby.exe" -x "%RUBY_BIN%hiera" %*

Comment by Michael Smith [ 2016/02/03 ]

Note the commit had the wrong ticket number (HI-943 instead of HI-493). https://github.com/puppetlabs/hiera/pull/340

Comment by Melissa Stone [ 2016/02/05 ]

Eric Thompson are you still the person to bug about tickets like this?

Comment by Eric Thompson [ 2016/02/09 ]

validated on windows2012r2 at master SHA: 18ebd9ad3cdb6c54140db83c251ed77f3023a6b6

PS C:\Users\Administrator> hiera.bat --version
3.0.5

Comment by Melissa Stone [ 2016/02/10 ]

This change just updates the functionality of the batch files, but should preserve existing functionality for anyone currently using these files

Generated at Fri Jul 03 20:38:39 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.