[MODULES-8438] SQLServer fact doesn't detect 2019 Created: 2019/01/07  Updated: 2019/01/16  Resolved: 2019/01/16

Status: Resolved
Project: Modules
Component/s: sqlserver
Affects Version/s: None
Fix Version/s: None

Type: New Feature Priority: Normal
Reporter: Paul Anderson Assignee: William Hurt
Resolution: Fixed Votes: 0
Labels: customer-escalation
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MODULES-6168 SQLServer fact doesn't detect 2017 Resolved
Template:
Acceptance Criteria:

Running the module should correctly detect that there
is no SQL 2017 instance installed on the host.

Running the module should correctly install SQL 2017 on the host.

Running the module should only install an instance once.

Confirm other installation conforms to previous behavior.

No additional support for 2019 features.
Code change.
Documented manual verification (add to this ticket).

Epic Link: Windows Customer Escalations
Team: Windows
Story Points: 1
Sprint: Windows 2019-01-16
QA Risk Assessment: Needs Assessment

 Description   

I'm working with a user of the Puppetlabs/SQLServer module. They're beginning to investigate SQLServer 2019 and find that the module doesn't detect it and attempts to re-install it on each Puppet run.

The appropriate fact(s) need to be updated to detect if SQLServer 2019 is installed on the system. (Managing it is another issue, but for another time).

This will allow them to intelligently manage state of their SQLServer instances.



 Comments   
Comment by Erick Banks [ 2019/01/09 ]

Ethan Brown to review

Comment by William Hurt [ 2019/01/14 ]

Manual Verification Method:
1. Provision server
2. Use the current master branch and a SQL 2019 ISO to install sql server (This is successful)
3. Verify that any further Puppet run cannot detect the new installation and attempt to install again.
a. This did occur. The facts gathered by the module cannot detect a 2019 instance and the install is invoked again.
b. The result of the run is an error because the installer returns an error when a duplication install is attempted.
4. Switch to the feature branch
5. Do another Puppet run and verify that the module now behaves properly.
a. It can now detect that an 2019 instance is already installed and does not attempt another install.
6. Change the ensure parameter to absent and verify that un install is executed. (it was)
7. Restart the system under test and use the feature branch to ensure an install is invoked if there is no 2019 instance. (it was)

Comment by Ethan Brown [ 2019/01/14 ]

Left a handful of comments on the PR

Comment by Ethan Brown [ 2019/01/15 ]

Merged to master in https://github.com/puppetlabs/puppetlabs-sqlserver/commit/d2a0f0729c1883a1cd68105aabbadabe3fba735e

Comment by Ethan Brown [ 2019/01/15 ]

Could you file a ticket for updating tests as described in https://github.com/puppetlabs/puppetlabs-sqlserver/pull/285#issuecomment-454588289 William Hurt? Thanks!

Comment by Ethan Brown [ 2019/01/15 ]

I think we also need some release notes about how the .NET 3.5 fix tagged along for the ride (especially if it's already been filed in another ticket)

Generated at Mon Dec 09 13:52:01 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.