[PCP-814] Stop writing parameters for task execution to disk Created: 2017/10/24  Updated: 2019/12/05  Resolved: 2019/04/24

Status: Resolved
Project: Puppet Communications Protocol
Component/s: pxp-agent
Affects Version/s: None
Fix Version/s: pxp-agent 1.9.10, pxp-agent 1.10.7, pxp-agent 1.11.2

Type: Improvement Priority: Major
Reporter: Michael Smith Assignee: Scott McClellan
Resolution: Fixed Votes: 2
Labels: resolved-issue-added
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
Template:
Team: Skeletor
Story Points: 1
Sprint: Skeletor Kanban, Skeletor Kanban, Skeletor Kanban
Zendesk Ticket IDs: 34049
Zendesk Ticket Count: 1
Release Notes: Security Fix
Release Notes Summary: pxp-agent parameters will no longer be logged or written to disk.
QA Risk Assessment: Needs Assessment

 Description   

Parameters may be sensitive, so avoid writing them to spool-dir and logging at info level.



 Comments   
Comment by Yasmin Rajabi [ 2018/02/20 ]

If they're sensitive would they have REDACTED logged?

Comment by Michael Smith [ 2018/02/20 ]

We could do that. They're only used for debugging currently, and some details might be better than none.

Comment by Scott McClellan [ 2019/04/08 ]

I'm getting this error trying to install Leatherman, so I wasn't able to run any of the code locally:

[ 23%] Building CXX object json_container/CMakeFiles/leatherman_json_container.dir/src/json_container.cc.o
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:20:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/reader.h:23:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/stack.h:38:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:20:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/reader.h:23:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/stack.h:38:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:20:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/reader.h:23:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/stack.h:60:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:20:
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/reader.h:23:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/stack.h:60:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/internal/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:62:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:62:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:438:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:438:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:600:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:600:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1042:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1042:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1303:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1303:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1738:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1738:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1757:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:4:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/document.h:1757:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:34: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
                                 ^
In file included from /Users/scott.mcclellan/IdeaProjects/leatherman/json_container/src/json_container.cc:5:
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/stringbuffer.h:20:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if RAPIDJSON_HAS_CXX11_RVALUE_REFS
    ^
/Users/scott.mcclellan/IdeaProjects/leatherman/build/src/rapidjson/include/rapidjson/error/../rapidjson.h:442:6: note: expanded from macro 'RAPIDJSON_HAS_CXX11_RVALUE_REFS'
    (defined(_LIBCPP_VERSION) || defined(__GLIBCXX__) && __GLIBCXX__ >= 20080306)
     ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [json_container/CMakeFiles/leatherman_json_container.dir/src/json_container.cc.o] Error 1
make[1]: *** [json_container/CMakeFiles/leatherman_json_container.dir/all] Error 2
make: *** [all] Error 2

Nonetheless, I put up this PR: https://github.com/puppetlabs/pxp-agent/pull/742

Comment by Michael Smith [ 2019/04/09 ]

Looks like a new warning in clang. Try adding -DCMAKE_CXX_FLAGS=-Wno-expansion-to-defined when running cmake.

Or build it with puppet-agent.

Comment by Scott McClellan [ 2019/04/09 ]

Michael Smith That fixed the issue for me. Should that addition live in docs or code?

Comment by Michael Smith [ 2019/04/09 ]

Probably added to leatherman, either as preprocessor pragmas to disable the warning or a CXX flag.

Comment by Scott McClellan [ 2019/04/09 ]

Should cpp-hocon be listed as a dependency? I'm seeing this now when I run cmake:

CMake Error at /usr/local/Cellar/cmake/3.14.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  cpp-hocon was not found.  (missing: CPPHOCON_LIBRARY CPPHOCON_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.14.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  vendor/FindDependency.cmake:28 (find_package_handle_standard_args)
  cmake/FindCPPHOCON.cmake:2 (find_dependency)
  CMakeLists.txt:66 (find_package) 

Then when trying to build cpp-hocon:

1%] Building CXX object lib/CMakeFiles/libprojectsrc.dir/src/values/config_object.cc.o
In file included from /Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/src/values/config_object.cc:1:
In file included from /Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/inc/hocon/config_object.hpp:3:
In file included from /Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/inc/hocon/config_value.hpp:4:
In file included from /Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/inc/hocon/config_origin.hpp:3:
In file included from /Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/inc/hocon/types.hpp:3:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3706:5: error: destructor called on non-final 'hocon::config_delayed_merge_object' that has virtual functions but non-virtual
      destructor [-Werror,-Wdelete-non-virtual-dtor]
    __data_.second().~_Tp();
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3667:9: note: in instantiation of member function 'std::__1::__shared_ptr_emplace<hocon::config_delayed_merge_object,
      std::__1::allocator<hocon::config_delayed_merge_object> >::__on_zero_shared' requested here
        __shared_ptr_emplace(_Alloc __a, _Args&& ...__args)
        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4327:26: note: in instantiation of function template specialization
      'std::__1::__shared_ptr_emplace<hocon::config_delayed_merge_object, std::__1::allocator<hocon::config_delayed_merge_object> >::__shared_ptr_emplace<std::__1::shared_ptr<const hocon::config_origin>,
      std::__1::vector<std::__1::shared_ptr<const hocon::config_value>, std::__1::allocator<std::__1::shared_ptr<const hocon::config_value> > > >' requested here
    ::new(__hold2.get()) _CntrlBlk(__a2, _VSTD::forward<_Args>(__args)...);
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4706:29: note: in instantiation of function template specialization
      'std::__1::shared_ptr<hocon::config_delayed_merge_object>::make_shared<std::__1::shared_ptr<const hocon::config_origin>, std::__1::vector<std::__1::shared_ptr<const hocon::config_value>,
      std::__1::allocator<std::__1::shared_ptr<const hocon::config_value> > > >' requested here
    return shared_ptr<_Tp>::make_shared(_VSTD::forward<_Args>(__args)...);
                            ^
/Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/src/values/config_object.cc:54:16: note: in instantiation of function template specialization 'std::__1::make_shared<hocon::config_delayed_merge_object, std::__1::shared_ptr<const
      hocon::config_origin>, std::__1::vector<std::__1::shared_ptr<const hocon::config_value>, std::__1::allocator<std::__1::shared_ptr<const hocon::config_value> > > >' requested here
        return make_shared<config_delayed_merge_object>(move(origin), move(stack));
               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3706:23: note: qualify call to silence this warning
    __data_.second().~_Tp();
                      ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3706:5: error: destructor called on non-final 'hocon::config' that has virtual functions but non-virtual destructor
      [-Werror,-Wdelete-non-virtual-dtor]
    __data_.second().~_Tp();
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3667:9: note: in instantiation of member function 'std::__1::__shared_ptr_emplace<hocon::config, std::__1::allocator<hocon::config>
      >::__on_zero_shared' requested here
        __shared_ptr_emplace(_Alloc __a, _Args&& ...__args)
        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4327:26: note: in instantiation of function template specialization 'std::__1::__shared_ptr_emplace<hocon::config,
      std::__1::allocator<hocon::config> >::__shared_ptr_emplace<std::__1::shared_ptr<const hocon::config_object> >' requested here
    ::new(__hold2.get()) _CntrlBlk(__a2, _VSTD::forward<_Args>(__args)...);
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4706:29: note: in instantiation of function template specialization
      'std::__1::shared_ptr<hocon::config>::make_shared<std::__1::shared_ptr<const hocon::config_object> >' requested here
    return shared_ptr<_Tp>::make_shared(_VSTD::forward<_Args>(__args)...);
                            ^
/Users/scott.mcclellan/IdeaProjects/cpp-hocon/lib/src/values/config_object.cc:58:16: note: in instantiation of function template specialization 'std::__1::make_shared<hocon::config, std::__1::shared_ptr<const hocon::config_object> >'
      requested here
        return make_shared<config>(dynamic_pointer_cast<const config_object>(shared_from_this()));
               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3706:23: note: qualify call to silence this warning
    __data_.second().~_Tp();
                      ^
2 errors generated.
make[2]: *** [lib/CMakeFiles/libprojectsrc.dir/src/values/config_object.cc.o] Error 1
make[1]: *** [lib/CMakeFiles/libprojectsrc.dir/all] Error 2
make: *** [all] Error 2 

Comment by Michael Smith [ 2019/04/09 ]

cpp-hocon is a dependency of pxp-agent.

Looks like another new warning. That looks like it needs a fix for the destructor (either the class needs to be final or the destructor needs to be virtual. You can also work around it with -Wno-delete-non-virtual-dtor in CMAKE_CXX_FLAGS.

The key to reading these is the [-Werror,-Wdelete-non-virtual-dtor], which states that it's failing because we've defined -Werror to say "all warnings should cause compilation to fail", and then the specific warning that's causing it which we enable with -Wall somewhere.

Comment by Yasmin Rajabi [ 2019/04/24 ]

Scott McClellan hey what version is this going out in?

Comment by Scott McClellan [ 2019/04/24 ]

Yasmin Rajabi It should be 1.9.8 (next tag in pxp-agent).

Generated at Mon Aug 10 23:31:56 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.