[PDB-1029] PR (1156): (PUP-3512) Use new Profiler API - fpringvaldsen Created: 2014/11/13  Updated: 2016/04/27  Resolved: 2014/11/19

Status: Closed
Project: PuppetDB
Component/s: None
Affects Version/s: PDB 2.2.2
Fix Version/s: PDB 2.3.0

Type: Bug Priority: Normal
Reporter: gepetto-bot Assignee: Preben Ingvaldsen
Resolution: Fixed Votes: 0
Labels: github
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Story Points: 0
Sprint: PuppetDB 2014-11-19, PuppetDB 2014-12-03

 Description   

(PUP-3512) Use new Profiler API

Pull Request Description


This PR modifies PuppetDB to use the new Puppet Profiler API instead of the old one, in preparation for the removal of the old API.


(webhooks-id: 38ed476c297298540179af957d539e14)



 Comments   
Comment by gepetto-bot [ 2014/11/13 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/189/

Comment by gepetto-bot [ 2014/11/14 ]

kbarber commented:

@fpringvaldsen this will need a stable branch target. Feel free to fix these comments from @cprice404 first before rebasing.

Can I ask you both a question, what does this hierarchy that is a metric_id mean? And what is its goal?

In the Ruby puppet profiler, it has this capability to enumerate where in the stack tree the profile is being called from, looking at this new one: https://github.com/puppetlabs/puppet-server/blob/f833bf81498400517c7e1fa1eea1d7161b6c03cb/src/java/com/puppetlabs/puppetserver/LoggingPuppetProfiler.java, I can't see how it does it here.

I guess what I'm trying to say is, are we still showing the stack level in the profile? Your request.key thing made me think about hierarchy thats all, but the previous system kind of did that automatically.

Comment by gepetto-bot [ 2014/11/14 ]

fpringvaldsen commented:

@cprice404 I've addressed your comments.

@kbarber I'll go ahead and rebase this onto stable now that I've addressed @cprice404's feedback. In terms of the metric ID, from what I understand it's used for grouping metrics together, and is sort of like a namespace. I'm not sure if we're still showing the stack level in the profile, but I think @cprice404 would be able to answer that.

Comment by gepetto-bot [ 2014/11/14 ]

cprice404 commented:

@kbarber this doesn't change the logging behavior you're used to seeing in the Puppet ruby profiler code. The logging profiler in Puppet Server probably needs to be updated a bit to follow that same pattern; have been planning to do that but haven't gotten to it yet.

Where this stuff really adds value is in PE when you are exporting the metrics to graphite; the new API allows us to provide hierarchy info to graphite and track counts/timing information at each level of the hierarchy.

Comment by gepetto-bot [ 2014/11/14 ]

fpringvaldsen commented:

I'm closing this in favor of https://github.com/puppetlabs/puppetdb/pull/1157, which is rebased on top of and targeted at stable.

Comment by gepetto-bot [ 2014/11/14 ]

Pull request (PUP-3512) Use new Profiler API has been closed.

Comment by gepetto-bot [ 2014/11/14 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/200/

Generated at Thu Jun 20 02:41:20 PDT 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.