[PDB-1042] PR (1163): Fixes needed for running tests against puppet's master branch - senior Created: 2014/11/25  Updated: 2015/05/05  Resolved: 2014/12/05

Status: Closed
Project: PuppetDB
Component/s: None
Affects Version/s: PDB 2.2.2
Fix Version/s: PDB 2.3.0, PDB 3.0.0

Type: Bug Priority: Normal
Reporter: gepetto-bot Assignee: Ryan Senior
Resolution: Fixed Votes: 0
Labels: github
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PDB-841 Retire (or at least consider retiring... Closed
Template:
Epic Link: PDB Puppet 4 Breaking changes
Story Points: 5
Sprint: PuppetDB 2014-12-03, PuppetDB 2014-12-17
QA Contact: Kurt Wall

 Description   

Fixes needed for running tests against puppet's master branch

Pull Request Description


Specifically this commit

  • Adds specific checks for puppet 3 when loading storeconfig code
    storeconfig does not work against current master and will be removed
    as part of Puppet 4.0.0. We want to maintain backward compatibility,
    so the code supports both
  • Removes references to Puppet[:trusted_node_data] when on Puppet
    4 (essentially assuming it is always true on 4). Like above we will
    look for it when on Puppet 3.y.z and ignore it (assuming true) when
    on Puppet 4.y.z

(webhooks-id: 6e423258266cb4a80ab7cbb051f8eb71)


QA Risk Assessment

N/A for testing tickets



 Comments   
Comment by gepetto-bot [ 2014/11/25 ]

senior commented:

The PR with the current state on master should have two spec test failures, due to a bug in Puppet. This PR https://github.com/puppetlabs/puppet/pull/3344 fixes that. Once it is merge in and merged up to master, we should be all green.

Comment by gepetto-bot [ 2014/11/25 ]

pljenkinsro commented:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/234/

Comment by gepetto-bot [ 2014/11/26 ]

kbarber commented:

I get the dreaded `Error: Attempt to assign to a reserved variable name: 'trusted' on node kb.local` when I try to use trusted node data with this patch.

Comment by gepetto-bot [ 2014/11/26 ]

kbarber commented:

@pljenkinsro retest this please

Comment by gepetto-bot [ 2014/11/26 ]

pljenkinsro commented:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/235/

Comment by gepetto-bot [ 2014/12/01 ]

senior commented:

@kbarber there's also two acceptance test failures, my guess is the fact_storage one is related to whatever is going on with the trusted stuff now. I'm working on the fix for the two failures now.

Comment by gepetto-bot [ 2014/12/01 ]

pljenkinsro commented:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr2/2/

Comment by gepetto-bot [ 2014/12/02 ]

pljenkinsro commented:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/248/

Comment by gepetto-bot [ 2014/12/03 ]

pljenkinsro commented:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/261/

Comment by gepetto-bot [ 2014/12/03 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/262/

Comment by gepetto-bot [ 2014/12/03 ]

senior commented:

@hlindberg BTW I had to remove the puppet feature stuff as it isn't working for me. I think it's a load order sort of issue, it was breaking our acceptance tests, moving that method from a feature to just a plain utility method fixed the issue.

Comment by gepetto-bot [ 2014/12/03 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/263/

Comment by gepetto-bot [ 2014/12/03 ]

wkalt commented:

+1

Comment by gepetto-bot [ 2014/12/03 ]

senior commented:

@wkalt fixed the spelling issue

Comment by gepetto-bot [ 2014/12/03 ]

pljenkinsro commented:

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/264/

Comment by gepetto-bot [ 2014/12/04 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/265/

Comment by gepetto-bot [ 2014/12/04 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/266/

Comment by gepetto-bot [ 2014/12/05 ]

Pull request Fixes needed for running tests against puppet's master branch has been closed.

Generated at Fri Oct 18 02:00:51 PDT 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.