[PDB-1247] Get the TK max-threads fixes on stable Created: 2015/02/23  Updated: 2016/04/27  Resolved: 2015/03/11

Status: Closed
Project: PuppetDB
Component/s: None
Affects Version/s: PDB 2.2.2
Fix Version/s: PDB 2.3.0

Type: Bug Priority: Normal
Reporter: Ryan Senior Assignee: Russell Mull
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
is blocked by TK-133 Restore comma-delimited string for ss... Resolved
relates to ENTERPRISE-453 trapperkeeper-webserver-jetty9 defaul... Closed
Story Points: 2
Sprint: PuppetDB 2015-03-11


This ticket covers backporting PDB-813 to stable. Ken Barber things this should apply pretty easily to stable. Specifically we want to get the max-threads related fixes in the next PE release. If back porting PDB-813 turns out to be more trouble than it's worth, Chris Price has offered to backport the change to make it so we don't need to upgrade.

Comment by Chris Price [ 2015/02/23 ]

s/has offered to backport/has offered to provide guidance to assist with a backport/g

Comment by Ken Barber [ 2015/02/23 ]

Here's the commit for the original patch fwiw: https://github.com/puppetlabs/puppetdb/commit/ea8f6965bb7f02692b30e5f6447ca79ca42f0e6e

Comment by Russell Mull [ 2015/02/25 ]

Talked with Chris Price about this today. Two options appeared reasonable:

1. Upgrade stable to the latest TK, but munge the config at startup to move cert-whitelist from the jetty section to the puppetdb section at runtime. This would mean backporting at least some of the code which looks for it in the new section.

2. Copy in the code that calculates the default max-threads at startup, and inject it into the config if there isn't already something there. This leaves TK and the associated dependencies where they are.

Currently leaning towards #2, but it depends on the lifetime of stable. Ryan Senior, do you know how long this branch will have to last? I presume that whatever we do here will be what we have to live with for 2.3.x as well, yes?

Comment by Russell Mull [ 2015/02/26 ]

Upon further investigation, PDB-813 already included code to handle old-style cert-whitelist config. Since it applies pretty cleanly to stable, I'm going with a straight backport.

Generated at Mon Sep 23 13:31:59 PDT 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.