[PDB-1247] Get the TK max-threads fixes on stable Created: 2015/02/23 Updated: 2016/04/27 Resolved: 2015/03/11
|Affects Version/s:||PDB 2.2.2|
|Fix Version/s:||PDB 2.3.0|
|Reporter:||Ryan Senior||Assignee:||Russell Mull|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
This ticket covers backporting
|Comment by Chris Price [ 2015/02/23 ]|
s/has offered to backport/has offered to provide guidance to assist with a backport/g
|Comment by Ken Barber [ 2015/02/23 ]|
Here's the commit for the original patch fwiw: https://github.com/puppetlabs/puppetdb/commit/ea8f6965bb7f02692b30e5f6447ca79ca42f0e6e
|Comment by Russell Mull [ 2015/02/25 ]|
Talked with Chris Price about this today. Two options appeared reasonable:
1. Upgrade stable to the latest TK, but munge the config at startup to move cert-whitelist from the jetty section to the puppetdb section at runtime. This would mean backporting at least some of the code which looks for it in the new section.
2. Copy in the code that calculates the default max-threads at startup, and inject it into the config if there isn't already something there. This leaves TK and the associated dependencies where they are.
Currently leaning towards #2, but it depends on the lifetime of stable. Ryan Senior, do you know how long this branch will have to last? I presume that whatever we do here will be what we have to live with for 2.3.x as well, yes?
|Comment by Russell Mull [ 2015/02/26 ]|
Upon further investigation,