[PDB-1436] PR (1354): (MAINT) Build pe-puppetdb from this repo. - waynr Created: 2015/04/15  Updated: 2015/07/10  Resolved: 2015/04/21

Status: Closed
Project: PuppetDB
Component/s: None
Affects Version/s: None
Fix Version/s: PDB 3.0.0

Type: Task Priority: Normal
Reporter: gepetto-bot Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: github
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Story Points: 0
Sprint: PuppetDB 2015-04-22

 Description   

(MAINT) Build pe-puppetdb from this repo.

Pull Request Description



(webhooks-id: b3a0cef1aa0bb097fbaf5208973f98e9)



 Comments   
Comment by gepetto-bot [ 2015/04/15 ]

pljenkinsro commented:

Can one of the admins verify this patch?

Comment by gepetto-bot [ 2015/04/16 ]

kbarber commented:

@waynr what's the syntax to test this mate? ```lein with-profile pe ezbake build``` etc.? I just want to see if I can make it work end-to-end myself as a bit of a functional test, any other pointers would be useful.

Comment by gepetto-bot [ 2015/04/16 ]

waynr commented:

@kbarber strange, I didn't see your comment show up in my inbox...gotta muck around with email filters some more I suppose.

To test this, try `lein with-profile ezbake,pe ezbake build`. We could probably eliminate the need for the `ezbake` profile but I have been thinking of the `pe` profile as building on top of that.

Comment by gepetto-bot [ 2015/04/17 ]

kbarber commented:

@waynr hehehe ... new git lesson I've just learnt. Check this out:

```
[ken@kb puppetdb]# git fetch -u waynr +maint:maint
error: there are still refs under 'refs/heads/maint'
error: Cannot lock the ref 'refs/heads/maint'.
From git://github.com/waynr/puppetdb
! [new branch]maint-> maint (unable to update local ref)
ruby-2.0.0-p481@puppetdb (git)-[master]
[ken@kb puppetdb]# git branch -d maint
error: branch 'maint' not found.
ruby-2.0.0-p481@puppetdb (git)-[master]
[ken@kb puppetdb]# ls .git/refs/heads/maint
master stable
```

Because I have branches in my clone that use maint/stable/name-of-patch it lays them out in folders in .git, but because your branch is called `maint` it refuses to do anything, it wants to create a file, but there is a directory. The lesson here is, because of our naming conventions you probably should avoiding calling any branch 'maint' as it will conflict with stuff like 'maint/stable/foo' which has been a convention at PL for quite some time. Fun fun fun. The solution for me was obviously:

```
[ken@kb puppetdb]# git fetch -u waynr maint:maint-foo
From git://github.com/waynr/puppetdb

  • [new branch]maint-> maint-foo
    ```

So I just call it `maint-foo` locally just for me.

Comment by gepetto-bot [ 2015/04/17 ]

kbarber commented:

My VPN isn't working ATM after that renewal we did, so I can't do this right now anyway. If anyone else on the team has the time and access to test this out, feel free - don't wait for me.

Comment by gepetto-bot [ 2015/04/17 ]

ajroetker commented:

:+1: package built successfully for me

http://jenkins-release.delivery.puppetlabs.net/job/pe-puppetdb-packaging-2015-04-17-15-13-17-0.1.0.SNAPSHOT.2015.04.17T1513

Comment by gepetto-bot [ 2015/04/17 ]

ajroetker commented:

@kbarber do the PE packaging templates for puppetdb have parity with the pe-puppetdbhttps://github.com/puppetlabs/pe-puppetdb repo's templates?

Comment by Ken Barber [ 2015/04/20 ]

AJ Roetker well, pe-puppetdb only reflects stable (2.x), and is non-ezbake. This stuff is for master (3.x), and involves ezbake. I would imagine the files involved would be similar I guess, but not the same. There were a lot of changes, it really depends on what templates you are exactly talking about.

Comment by gepetto-bot [ 2015/04/20 ]

kbarber commented:

@ajroetker well, pe-puppetdb only reflects stable (2.x), and is non-ezbake. This stuff is for master (3.x), and involves ezbake. I would imagine the files involved would be similar I guess, but definitely not the same. There were a lot of changes, it really depends on what templates you are exactly talking about.

Comment by gepetto-bot [ 2015/04/20 ]

Pull request (MAINT) Build pe-puppetdb from this repo. has been closed.

Generated at Thu Feb 27 00:44:36 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.