[PDB-1556] PR (1425): (maint) Remove unneccesary querying macro to improve streaming syntax - ajroetker Created: 2015/05/28  Updated: 2015/07/10  Resolved: 2015/06/02

Status: Closed
Project: PuppetDB
Component/s: None
Affects Version/s: None
Fix Version/s: PDB 3.0.0

Type: Task Priority: Normal
Reporter: gepetto-bot Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: github
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Story Points: 1
Sprint: PuppetDB 2015-06-03

 Description   

(maint) Remove unneccesary querying macro to improve streaming syntax

Pull Request Description


This commit removes the `with-query-results-cursor` macro, as it was
functionally unused. The macro wrapped `with-query-results-cursor*` with a
different interface, but the only thing that used the macro was
`streamed-query-results` which wrapped the macro in the original
interface of `with-query-results-cursor*`. This commit collapses these
functions/macros.
This commit also cleans up some syntax in jdbc, removing unnecessary
parens.


(webhooks-id: fa17b239ff3221cbf54052c3f3ecb143)



 Comments   
Comment by gepetto-bot [ 2015/05/28 ]

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1326/

Comment by gepetto-bot [ 2015/05/29 ]

mullr commented:

generally looks ok, just some minor comments

Comment by gepetto-bot [ 2015/06/01 ]

ajroetker commented:

@mullr Also I know this is maint but it relates the hack-day project I wanted to work on... transducers, so I would be really grateful if we could get this merged by tomorrow

Comment by gepetto-bot [ 2015/06/01 ]

mullr commented:

alright, :+1: from me then

Comment by gepetto-bot [ 2015/06/01 ]

wkalt commented:

looks good to me

Comment by gepetto-bot [ 2015/06/01 ]

Pull request (maint) Remove unneccesary querying macro to improve streaming syntax has been closed.

Generated at Sat Feb 22 15:14:14 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.