[PDK-1032] Fix multi-spinner display when doing parallel batched validation Created: 2018/06/14  Updated: 2019/11/04

Status: Accepted
Project: Puppet Development Kit
Component/s: None
Affects Version/s: None
Fix Version/s: PDK December 2019

Type: Bug Priority: Minor
Reporter: Bryan Jen Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PDK-985 `pdk validate` on large set of files:... Closed
Template:
Epic Link: PDK Maintenance
Team: Puppet Developer Experience
Method Found: Needs Assessment
QA Risk Assessment: Needs Assessment

 Description   

From PDK-985

There seem to be some issues with how the new code interacts with the multispinner:
 
$ lpdk validate --parallel
pdk (INFO): Running all available validators...
pdk (INFO): Using Ruby 2.4.4
pdk (INFO): Using Puppet 5.5.1
┌ [✔] Validating module using 3 threads        ┌
└──[✔] Checking metadata syntax (metadata.json ┌ ─ks/*.json).
└──[/] Checking module metadata style (metadata├──on).
└──[✔] Checking module metadata style (metadata├──on).
└──[✔] Checking task metadata style (tasks/*.json).
[✔] Checking Puppet manifest syntax (**/**.pp).
[✔] Checking Puppet manifest style (**/*.pp).
convention: rubocop: spec/unit/puppet/provider/testprovider/testprovider_spec.rb:4:1: Style/Documentation: Missing top-level module documentation comment.
vs master:
 
pdk (INFO): Running all available validators...
pdk (INFO): Using Ruby 2.4.4
pdk (INFO): Using Puppet 5.5.1
┌ [✖] Validating module using 3 threads
├──[✖] Checking Ruby code style (**/**.rb).
├──[✔] Checking metadata syntax (metadata.json tasks/*.json).
├──[✔] Checking Puppet manifest syntax (**/**.pp).
├──[✔] Checking module metadata style (metadata.json).
├──[✔] Checking task metadata style (tasks/*.json).
└──[✔] Checking Puppet manifest style (**/*.pp).
convention: rubocop: spec/unit/puppet/provider/testprovider/testprovider_spec.rb:4:1: Style/Documentation: Missing top-level module documentation comment.
I'm going to see if I can figure out what is going on.


Generated at Mon Dec 09 12:48:19 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.