[PDK-1054] parallel_spec(_prep) fails on appveyor Created: 2018/06/27  Updated: 2018/07/26  Resolved: 2018/06/28

Status: Closed
Project: Puppet Development Kit
Component/s: None
Affects Version/s: PDK 1.6.0
Fix Version/s: PDK 1.6.1

Type: Bug Priority: Major
Reporter: David Schmitt Assignee: Tim Sharpe
Resolution: Fixed Votes: 0
Labels: resolved-issue-added
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

appveyor: https://ci.appveyor.com/project/puppetlabs/puppetlabs-resource-api/build/1.1.x.16/job/6xp9wwki0b5mui5o
pdk-templates: master-0-g473cd94

Method Found: Needs Assessment
Release Notes: Bug Fix
Release Notes Summary: Fixed a bug upstream in rspec-puppet where running parallel tests with puppetlabs_spec_helper on Windows under Ruby 2.1 would intermittently fail while checking if the fixture directory junction exists.
QA Risk Assessment: Needs Assessment


When running parallel_spec on appveyor, the spec_prep seems to run multiple times, and subsequently fail the test process because Cannot create a file when that file already exists. (See https://ci.appveyor.com/project/puppetlabs/puppetlabs-resource-api/build/1.1.x.16/job/6xp9wwki0b5mui5o#L749).

This looks like the symlink creating code in puppetlabs_spec_helper is not idempotent enough on windows.

Comment by Tim Sharpe [ 2018/06/28 ]

Self merged after a thumbs up review from David Schmitt

Generated at Tue Nov 19 15:28:35 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.