[PDK-1211] PDK update/convert ignore's .gitattribute file Created: 2018/11/02 Updated: 2018/11/29 Resolved: 2018/11/26 |
|
Status: | Closed |
Project: | Puppet Development Kit |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | PDK 1.8.0 |
Type: | Bug | Priority: | Normal |
Reporter: | David Swan | Assignee: | Tim Sharpe |
Resolution: | Fixed | Votes: | 0 |
Labels: | resolved-issue-added | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified | ||
Environment: |
PDK 1.7.1 |
Template: | customfield_10700 283497 |
Method Found: | Needs Assessment |
Release Notes: | Bug Fix |
Release Notes Summary: | Fixes an issue where the .gitattributes file was not being managed by PDK. |
QA Risk Assessment: | Needs Assessment |
Description |
I was reviewing a PR for apt when I noticed that it was for the .gitattributes file which, to my knowledge, should have been managed by the PDK. |
Comments |
Comment by Tim Sharpe [ 2018/11/04 ] |
Yeah, .gitattributes was chosen to be managed at initialisation time only, so PDK update and convert won't touch it if it already exists. I think it's worth starting a discussion around whether we should change this behaviour. |
Comment by David Swan [ 2018/11/05 ] |
I think it would be better to keep it updated. We've had a change to the template for the file so know all the modules are out of date with it. |
Comment by Bryan Jen [ 2018/11/14 ] |
We can move the .gitattributes file to the moduleroot and have it actively managed. |