[PDK-1211] PDK update/convert ignore's .gitattribute file Created: 2018/11/02 Updated: 2018/11/29 Resolved: 2018/11/26
|Project:||Puppet Development Kit|
|Fix Version/s:||PDK 1.8.0|
|Reporter:||David Swan||Assignee:||Tim Sharpe|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Method Found:||Needs Assessment|
|Release Notes:||Bug Fix|
|Release Notes Summary:||Fixes an issue where the .gitattributes file was not being managed by PDK.|
|QA Risk Assessment:||Needs Assessment|
I was reviewing a PR for apt when I noticed that it was for the .gitattributes file which, to my knowledge, should have been managed by the PDK.
|Comment by Tim Sharpe [ 2018/11/04 ]|
Yeah, .gitattributes was chosen to be managed at initialisation time only, so PDK update and convert won't touch it if it already exists. I think it's worth starting a discussion around whether we should change this behaviour.
|Comment by David Swan [ 2018/11/05 ]|
I think it would be better to keep it updated. We've had a change to the template for the file so know all the modules are out of date with it.
|Comment by Bryan Jen [ 2018/11/14 ]|
We can move the .gitattributes file to the moduleroot and have it actively managed.