[PDK-998] Cannot use rubocop profile "off" with pdk update Created: 2018/05/29  Updated: 2018/06/21  Resolved: 2018/05/30

Status: Closed
Project: Puppet Development Kit
Component/s: None
Affects Version/s: None
Fix Version/s: PDK 1.6.0

Type: Bug Priority: Normal
Reporter: Rob Nelson Assignee: David Schmitt
Resolution: Fixed Votes: 0
Labels: resolved-issue-added
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Using PDK 1.5.0.0 from RPM on CentOS 7, pointed at the template-ref "heads/master-0-g7b5f6d2


Template:
Method Found: Needs Assessment
Release Notes: Bug Fix
Release Notes Summary: Fixed an issue preventing module developers from disabling rubocop checks via .sync.yml.
QA Risk Assessment: Needs Assessment

 Description   

It looks like I should be able to set a `selected_profile` of `off` in .sync.yml to disable rubocop, but that generates an error when using pdk update as it tries to loop through some empty hash for the profile.

[rnelson0@build03 domain_join:pdk±]$ tail -2 .sync.yml
.rubocop.yml:
  selected_profile: off
[rnelson0@build03 domain_join:pdk±]$ pdk update
pdk (FATAL): Failed to render template '.rubocop.yml.erb'
NoMethodError: undefined method `keys' for []:Array
 



 Comments   
Comment by David Schmitt [ 2018/05/30 ]

https://github.com/puppetlabs/pdk-templates/pull/102

Generated at Wed Mar 20 10:17:17 PDT 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.