[PUP-2838] Puppet generates invalid .dot files due to missing escapes of quoted strings in resource names Created: 2014/06/25 Updated: 2018/09/19 Resolved: 2018/05/22
|Affects Version/s:||PUP 3.6.1, PUP 3.6.2, PUP 5.5.1|
|Fix Version/s:||PUP 6.0.0|
|Reporter:||Tristan Helmich||Assignee:||Jacob Helwig|
|Labels:||community, puppethack, the-goods|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Template:||PUP Bug Template customfield_10700 40322|
|Release Notes:||Bug Fix|
|Release Notes Summary:||Generating graphs of catalogs (Eg: puppet apply --graph) now correctly handles resources with double quotes in the title.|
Puppet generates invalid .dot files.
Example content generated by puppet:
Correctly escaped it would look like this:
The behavior has been reproduced with Puppet 3.6.1 and 3.6.2
|Comment by Josh Holland [ 2014/12/12 ]|
|Comment by Beth Cornils [ 2014/12/31 ]|
Is this the ticket we discussed in IAC?
|Comment by Reid Vandewiele [ 2014/12/31 ]|
[~bcornils] No, I was talking about
|Comment by Scott Walker [ 2015/07/23 ]|
Beth Cornils I ran into this too generating a graph using the agent running on master. Is there any concern that introduction of graphs into the UI might draw users to try --graph with the agent?
|Comment by Verne Lindner [ 2015/07/23 ]|
Scott Walker I'm not following your comment about UI graphs and CL --graph use: would you explain what the concern is?
|Comment by Scott Walker [ 2015/07/24 ]|
Verne Lindner This ticket captures a bug in which the agent can generate dot files that aren't syntactically valid. If you use "--graph" on the master agent you get an example - in that case because of some unescaped quotes. My rationale is: the graph is now much more visible and so maybe customers are more likely to try out the --graph option on the agent. If they try it on their master in PE 2015.2 they'll run into the bug straight away.
Beth Cornils I hadn't thought of deprecating - I like it. There's probably still value in expanded_relationships.dot for agent debugging purposes but there's less reason to use it compared with the others.
|Comment by Verne Lindner [ 2015/07/24 ]|
|Comment by Romain Tartière [ 2018/05/19 ]|
Problem still exist with Puppet 5 but the symptoms are not the same: dot(1) complains that the .dot file is invalid:
λ dot /var/puppet/state/graphs/relationships.dot
The line 5765 says:
λ sed -e '5765!d' /var/puppet/state/graphs/relationships.dot
|Comment by Jacob Helwig [ 2018/05/21 ]|
PR merged to master branch in 81d213d80d.