[PUP-2952] Puppet should only log facts in debug mode Created: 2014/07/17  Updated: 2019/04/04  Resolved: 2014/08/04

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 3.7.0

Type: Bug Priority: Normal
Reporter: William Van Hevelingen Assignee: Adrien Thebo
Resolution: Fixed Votes: 2
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PUP-4999 In apply mode spurious loading facts ... Resolved
Template:
QA Contact: Eric Thompson

 Description   

In environments with lots of facts puppet agent can fill the screen and log files with loading fact messages. This is only useful when debugging and should thus be only enabled when in debug mode.

rickon:~# puppet agent --test
Info: Retrieving plugin
Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
Info: Loading facts in /var/lib/puppet/lib/facter/thunderbird_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/rabbitmq_erlang_cookie.rb
Info: Loading facts in /var/lib/puppet/lib/facter/is_lxc.rb
Info: Loading facts in /var/lib/puppet/lib/facter/collectd_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/staging_windir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
Info: Loading facts in /var/lib/puppet/lib/facter/sunray.rb
Info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/dns_ip_4.rb
Info: Loading facts in /var/lib/puppet/lib/facter/iptables_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/raidtype.rb
Info: Loading facts in /var/lib/puppet/lib/facter/staging_http_get.rb
Info: Loading facts in /var/lib/puppet/lib/facter/kernel_type.rb
Info: Loading facts in /var/lib/puppet/lib/facter/iptables_persistent_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/dns_ip_6.rb
Info: Loading facts in /var/lib/puppet/lib/facter/hardware_platform.rb
Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/ganeti_cluster.rb
Info: Loading facts in /var/lib/puppet/lib/facter/dept.rb
Info: Loading facts in /var/lib/puppet/lib/facter/nvidia_graphics_device.rb
Info: Loading facts in /var/lib/puppet/lib/facter/os_maj_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/ip6tables_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/raid_devices.rb
Info: Caching catalog for rickon.cat.pdx.edu
Info: Applying configuration version '1405637813'
Notice: Finished catalog run in 14.01 seconds

With the patch applied

rickon:~# puppet agent -t
Info: Retrieving plugin
Info: Caching catalog for rickon.cat.pdx.edu
Info: Applying configuration version '1405637813'
Notice: Finished catalog run in 14.01 seconds



 Comments   
Comment by Daniele Sluijters [ 2014/07/17 ]

Perhaps we could amend this to still output that it's loaded facts as not outputting it might confuse users.

Comment by Adrien Thebo [ 2014/07/30 ]

Merged in df7acc7.

Comment by Adrien Thebo [ 2014/08/04 ]

Verified against b7ce5e6; when running puppet agent -t the agent does not list out the fact files being loaded.

Generated at Wed Nov 13 11:56:06 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.