[PUP-3130] Remove "hidden" $_timestamp fact Created: 2014/08/22  Updated: 2016/10/19  Resolved: 2015/01/23

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 4.0.0

Type: Task Priority: Normal
Reporter: Kylo Ginsberg Assignee: Unassigned
Resolution: Done Votes: 0
Labels: docs_reviewed
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
blocks PDB-971 Retirement: Stop calling Facts#strip_... Closed
relates to PDB-337 _timestamp fact Closed
relates to PUP-3670 Remove Facts#strip_internal method Closed
relates to PUP-3129 Deprecate hidden _timestamp fact Closed
Epic Link: Code Removal Puppet 4
Story Points: 1
Sprint: Platform Client 2014-10-29, Platform Client 2014-11-12
QA Contact: Eric Thompson

Comment by Henrik Lindberg [ 2014/08/24 ]

FYI, this fact is removed in the PuppetDB terminus and is thus ok to remove (says Ken Barber).

Comment by Kylo Ginsberg [ 2014/10/24 ]

Nicholas Fagerlund this PR is now (quietly) deprecating strip_internal in Puppet 4.0. The "quiet" part is to avoid spamming the logs for PuppetDB users since that's the only known user of this call.

Comment by Nicholas Fagerlund [ 2014/10/24 ]

Ha, interesting. So this is a method that will be deprecated in 4.x and removed in 5.0? I think that's the first of those, isn't it?

Comment by Kylo Ginsberg [ 2014/10/24 ]

Yeah I think it is. Hooray! I think?

Comment by Nicholas Fagerlund [ 2014/10/24 ]

Coooool. Okay, I've filed DOC-1320 to track deprecated features for 4.0.

Comment by Eric Thompson [ 2014/11/03 ]

verified in debian wheezy at SHA c11546d with:

root@d95ifjj678c6vzh:/opt/puppet-git-repos/puppet# puppet apply -e 'notify {"$_timestamp": }'
Notice: Compiled catalog for d95ifjj678c6vzh.delivery.puppetlabs.net in environment production in 0.02 seconds
Notice: /Stage[main]/Main/Notify[]/message: defined 'message' as ''
Notice: Applied catalog in 0.02 seconds
Error: Failed to apply catalog: No title provided and "Notify[]" is not a valid resource reference

Generated at Thu Feb 27 16:23:09 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.