[PUP-3521] puppet incorrectly swallows some errors Created: 2014/09/15  Updated: 2019/04/04  Resolved: 2015/01/20

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 4.0.0

Type: Bug Priority: Normal
Reporter: Kevin Corcoran Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relates to PUP-6425 Regression: puppet help errors out if... Closed
relates to PUP-3656 Prefetch eats most exceptions (those ... Closed
Epic Link: Green: Puppet 4.0 Changes
Story Points: 3
Sprint: SERVER 2014-11-19, SERVER 2014-12-03, SERVER 2014-12-17, SERVER 2014/12/31, Server 2015-01-21
QA Contact: Ryan Gard


puppet has a lot of places that do rescue Exception and then swallow the exception. In some cases, the exception is not even logged.

At least, this code should be changed to handle StandardError instead, and the errors should always be logged.

This can be particularly problematic for certain errors - say, an OutOfMemoryError when running on JRuby, which ends up operating as a subclass of ruby's Exception. (although we've now solved this particular issue in packaging)

Comment by Josh Cooper [ 2014/12/19 ]

Merged to master in d7f7bb4dd

Generated at Mon Jan 27 11:19:55 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.