[PUP-3521] puppet incorrectly swallows some errors Created: 2014/09/15 Updated: 2019/04/04 Resolved: 2015/01/20
|Fix Version/s:||PUP 4.0.0|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Epic Link:||Green: Puppet 4.0 Changes|
|Sprint:||SERVER 2014-11-19, SERVER 2014-12-03, SERVER 2014-12-17, SERVER 2014/12/31, Server 2015-01-21|
puppet has a lot of places that do rescue Exception and then swallow the exception. In some cases, the exception is not even logged.
At least, this code should be changed to handle StandardError instead, and the errors should always be logged.
This can be particularly problematic for certain errors - say, an OutOfMemoryError when running on JRuby, which ends up operating as a subclass of ruby's Exception. (although we've now solved this particular issue in packaging)
|Comment by Josh Cooper [ 2014/12/19 ]|
Merged to master in d7f7bb4dd